feat(tags): add paste/input tag separators (#DS-4712) - #1894
Merged
Conversation
artembelik
changed the title
|
Visit the preview URL for this PR (updated for commit 9ca8a2c): https://koobiq-next--prs-1894-e4a4tvs4.web.app (expires Mon, 17 Aug 2026 07:50:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds separator-context support to the Tags input so separators can be scoped to typing vs paste, updates defaults/provider ergonomics, and extends docs + E2E coverage to demonstrate the new behavior.
Changes:
- Introduce
KbqTagSeparator.appliesToand support keyless (paste-only) separator regexes for paste splitting. - Replace
KBQ_TAGS_DEFAULT_OPTIONSmanual provider boilerplate withkbqTagsDefaultOptionsProvider(...)and update examples/usages accordingly. - Add unit + Playwright E2E coverage and documentation for separator scoping.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/public_api_guard/components/tags.api.md | Updates public API snapshot for new separator types and default-options provider helper. |
| packages/e2e/routes.ts | Registers the new tags separators E2E route/component. |
| packages/docs-examples/components/tags/tag-input-onpaste-off/tag-input-onpaste-off-example.ts | Switches to kbqTagsDefaultOptionsProvider for disabling add-on-paste. |
| packages/docs-examples/components/tags/tag-autocomplete-onpaste-off/tag-autocomplete-onpaste-off-example.ts | Switches to kbqTagsDefaultOptionsProvider for disabling add-on-paste. |
| packages/components/tags/tag.module.ts | Uses kbqTagsDefaultOptionsProvider for module-level defaults. |
| packages/components/tags/tag-input.ts | Implements separator scoping (appliesTo) and new default-options/provider API. |
| packages/components/tags/tag-input.spec.ts | Adds unit coverage for appliesTo behavior and updates default-options provisioning in tests. |
| packages/components/tags/tag-input.ru.md | Documents separator behavior and global defaults provider usage (RU). |
| packages/components/tags/tag-input.en.md | Documents separator behavior and global defaults provider usage (EN). |
| packages/components/tags/tag-default-options.ts | Removes the old default-options token/interface file (moved into tag-input.ts). |
| packages/components/tags/public-api.ts | Stops exporting removed tag-default-options entry point. |
| packages/components/tags/e2e.ts | Adds an E2E demo component for separator scoping and paste-only separators. |
| packages/components/tags/e2e.playwright-spec.ts | Adds Playwright tests verifying typing vs paste separator behavior. |
| packages/components-dev/tag/module.ts | Updates commented example to use kbqTagsDefaultOptionsProvider. |
Suppressed comments (1)
packages/components/tags/tag-input.ts:80
- This JSDoc also references the “chips module” even though the token configures the tags package. Consider updating the wording to match the public API surface.
/** Injection token to be used to override the default options for the chips module. */
export const KBQ_TAGS_DEFAULT_OPTIONS = new InjectionToken<KbqTagsDefaultOptions>('kbq-tags-default-options');
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
NikGurev
approved these changes
Aug 13, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
artembelik
force-pushed
the
feat/DS-4712
branch
from
August 14, 2026 07:46
c38752b to
9ca8a2c
Compare
lskramarov
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.